Reverting https://github.com/apache/pinot/pull/13645 PR #14259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14259 +/- ##
============================================
+ Coverage 61.75% 63.75% +2.00%
- Complexity 207 1535 +1328
============================================
Files 2436 2628 +192
Lines 133233 144989 +11756
Branches 20636 22184 +1548
============================================
+ Hits 82274 92438 +10164
- Misses 44911 45725 +814
- Partials 6048 6826 +778
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gortiz
approved these changes
Oct 22, 2024
Contributor
|
I'm thinking to merge this instead of #14275, but I had to re-launch tests before merging given all executions of test unit 2 had failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If servers have grpc TLS enabled, then multi-stage query fails.
curl -k -X POST -H 'accept: application/json' -H 'Content-Type: application/json' -d '{"sql":"select count(*) from transcript limit 10","trace":false,"queryOptions":"useMultistageEngine=true"}' https://<broker.blah.com>/query/sql
{"numRowsResultSet":0,"partialResult":true,"exceptions":[{"errorCode":200,"message":"QueryExecutionError:\nError dispatching query: 285819222000000000 to server: pinot-server-server-0-0.pinot-pinot-server-headless.cell-ctwxvh-managed.svc.cluster.local@{36243,40701}\norg.apache.pinot.query.service.dispatch.QueryDispatcher.execute(QueryDispatcher.java:259)\norg.apache.pinot.query.service.dispatch.QueryDispatcher.submit(QueryDispatcher.java:204)\norg.apache.pinot.query.service.dispatch.QueryDispatcher.submitAndReduce(QueryDispatcher.java:116)\norg.apache.pinot.broker.requesthandler.MultiStageBrokerRequestHandler.handleRequest(MultiStageBrokerRequestHandler.java:218)\nUNAVAILABLE: Network closed for unknown reason\nio.grpc.Status.asRuntimeException(Status.java:532)\nio.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:481)\nio.grpc.internal.DelayedClientCall$DelayedListener$3.run(DelayedClientCall.java:489)\nio.grpc.internal.DelayedClientCall$DelayedListener.delayOrExecute(DelayedClientCall.java:453)\n"}],"numGroupsLimitReached":false,"timeUsedMs":0,"requestId":"285819222000000000","brokerId":"Broker_pinot-broker-broker-0-0.pinot-pinot-broker-headless.cell-ctwxvh-managed.svc.cluster.local_8099","numDocsScanned":0,"totalDocs":0,"numEntriesScannedInFilter":0,"numEntriesScannedPostFilter":0,"numServersQueried":0,"numServersResponded":0,"numSegmentsQueried":0,"numSegmentsProcessed":0,"numSegmentsMatched":0,"numConsumingSegmentsQueried":0,"numConsumingSegmentsProcessed":0,"numConsumingSegmentsMatched":0,"minConsumingFreshnessTimeMs":0,"numSegmentsPrunedByBroker":0,"numSegmentsPrunedByServer":0,"numSegmentsPrunedInvalid":0,"numSegmentsPrunedByLimit":0,"numSegmentsPrunedByValue":0,"brokerReduceTimeMs":0,"offlineThreadCpuTimeNs":0,"realtimeThreadCpuTimeNs":0,"offlineSystemActivitiesCpuTimeNs":0,"realtimeSystemActivitiesCpuTimeNs":0,"offlineResponseSerializationCpuTimeNs":0,"realtimeResponseSerializationCpuTimeNs":0,"offlineTotalCpuTimeNs":0,"realtimeTotalCpuTimeNs":0,"explainPlanNumEmptyFilterSegments":0,"explainPlanNumMatchAllFilterSegments":0,"traceInfo":{}}This PR is reverting #13645