Support COALESCE as a variadic scalar function #14195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmayya
added
bugfix
multi-stage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14195 +/- ##
============================================
+ Coverage 61.75% 63.80% +2.05%
- Complexity 207 1534 +1327
============================================
Files 2436 2622 +186
Lines 133233 144396 +11163
Branches 20636 22103 +1467
============================================
+ Hits 82274 92133 +9859
- Misses 44911 45464 +553
- Partials 6048 6799 +751
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yashmayya
force-pushed
the
coalesce-scalar-variadic
branch
from
5a635ed to
03aaf50
Compare
Jackie-Jiang
approved these changes
Oct 9, 2024
| @Nullable | ||
| private static Object coalesceVar(Object... objects) { | ||
| @ScalarFunction(nullableParameters = true, isVarArg = true) | ||
| public static Object coalesce(Object... objects) { |
Contributor
There was a problem hiding this comment.
Let's keep the @Nullable annotation since it could return null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COALESCE.COALESCEthat already supports an arbitrary number of arguments) - so something likeCOALESCE(SUM(col1), SUM(col2), SUM(col3), SUM(col4), SUM(col5), SUM(col6)wouldn't work before this fix.