Fail multi-stage client queries in the broker if multi-stage engine is disabled #13732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmayya
added
user-experience
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13732 +/- ##
============================================
+ Coverage 61.75% 61.98% +0.23%
+ Complexity 207 198 -9
============================================
Files 2436 2554 +118
Lines 133233 140667 +7434
Branches 20636 21881 +1245
============================================
+ Hits 82274 87197 +4923
- Misses 44911 46837 +1926
- Partials 6048 6633 +585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gortiz
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET /queryandPOST /query(Add new broker query point for querying multi-stage engine #11341).pinot.multistage.engine.enabledand users issue a broker query request indicating that the multi-stage engine should be used, the query doesn't fail and instead falls back to using the single-stage engine.pinot/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java
Lines 173 to 180 in dd8a647