-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Apply SEARCH expand rule in the end #13614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@gortiz Can you help check if this also solves the problem? I feel this is a safer option without changing the query plan |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13614 +/- ##
============================================
+ Coverage 61.75% 61.96% +0.21%
+ Complexity 207 198 -9
============================================
Files 2436 2555 +119
Lines 133233 140710 +7477
Branches 20636 21862 +1226
============================================
+ Hits 82274 87190 +4916
- Misses 44911 46885 +1974
- Partials 6048 6635 +587
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This patch is not enough. There are several places where SEARCH is converted into ORs. This patch is attacking one of the places (our expand rule) but not the other I know, which is when calcite validates queries. There, Calcite uses |
|
Discussed offline. We will merge this one to reduce the overhead, in the meanwhile trying to figure out a thorough solution. |
(cherry picked from commit 4422e9a)
Another attempt of #13605, see more details there.
Comparing to #13605, this fix keeps the current behavior, but avoid the expensive processing or huge OR/AND list