bugfix: json_extract_index out of bounds case #13479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13479 +/- ##
============================================
+ Coverage 61.75% 61.97% +0.22%
+ Complexity 207 198 -9
============================================
Files 2436 2557 +121
Lines 133233 141195 +7962
Branches 20636 21914 +1278
============================================
+ Hits 82274 87506 +5232
- Misses 44911 47038 +2127
- Partials 6048 6651 +603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Jun 28, 2024
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_extract_index(col, '$.key', 'INT', 0)fails withjava.lang.ArrayIndexOutOfBoundsException: Index 10000 out of bounds for length 10000- there's a typo in one of the functions for converting toINT. This PR fixes this logic.Unit testing this case looks like a larger change, requiring refactoring most of the transform function test cases since they are currently only tested w/ a single
ValueBlock. The functionality is covered w/ the existing singleValueBlocktest