Codecov Report

❌ Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.06%. Comparing base (59551e4) to head (bf1120c).
⚠️ Report is 2926 commits behind head on master.

@@             Coverage Diff              @@
##             master   #13463      +/-   ##
============================================
+ Coverage     61.75%   62.06%   +0.31%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2559     +123     
  Lines        133233   141341    +8108     
  Branches      20636    21928    +1292     
============================================
+ Hits          82274    87727    +5453     
- Misses        44911    46950    +2039     
- Partials       6048     6664     +616     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CalciteSqlCompilerTest.testExtract is failing with:

Caught exception while invoking method: public static int org.apache.pinot.common.function.scalar.DateTimeFunctions.extract(java.lang.String,long) with arguments: [YEAR, 2017-06-15]

However, the test itself seems a little odd because even before the changes from this PR, while the test passes (i.e., the query compiles to a v1 Pinot query), trying to run an actual query like SELECT EXTRACT(YEAR FROM '2017-06-15') FROM table; results in a similar type related error:

Error Code: 200

QueryExecutionError:
java.lang.IllegalArgumentException: Invalid long value: 2017-06-15
	at org.apache.pinot.common.request.context.LiteralContext.getLongValue(LiteralContext.java:258)
	at org.apache.pinot.core.operator.transform.function.LiteralTransformFunction.getLongLiteral(LiteralTransformFunction.java:65)
	at org.apache.pinot.core.operator.transform.function.LiteralTransformFunction.transformToLongValuesSV(LiteralTransformFunction.java:141)
	at org.apache.pinot.core.operator.transform.function.ExtractTransformFunction.transformToIntValuesSV(ExtractTransformFunction.java:61)

@Jackie-Jiang can the test be updated to use timestamps in the form of milliseconds since epoch or is there some other missing context here?

The only reason the test wasn't failing earlier was that since there was no scalar function for EXTRACT, the compile time function invoker query rewriter skips evaluation here when the query rewrite rules are being invoked here during the Pinot query compilation. So, the test didn't make much sense since the EXTRACT function never supported timestamp strings (that aren't milliseconds since epoch) in the first place. I've updated the test and also rebased this on top of changes from #13483.