Make 'valueIn' MV transform function work with the multi-stage query engine #13443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmayya
force-pushed
the
value-in-v2-engine
branch
from
63011ec to
4243b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valueIn/VALUE_INtransform function didn't work with the multi-stage query engine and resulted in errors likeNo match found for function signature valueIn(<VARCHAR ARRAY>, <CHARACTER>, <CHARACTER>).TransformFunctionTypewhich are used while registering the Pinot transform functions in Calcite's operator table.VALUE_INfunction takes a multi-value column as its first input, followed by any number of constant value arguments. Hence, we're using Calcite's variadic operand type checker in this patch.SqlTypeFamily.ARRAY) with all but the first two being optional. This would however introduce an artificial limitation on the number of operands that theVALUE_INfunction can take (also it would look fairly ugly - both in code, as well as Calcite's generated function signature).