Skip to content

[Multi-stage] Fix literal handling #13344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jackie-Jiang merged 1 commit into from
Jun 8, 2024
Merged

[Multi-stage] Fix literal handling #13344

Jackie-Jiang merged 1 commit into from
Jun 8, 2024

Conversation

@Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Jun 8, 2024

  • Ensure literal is properly handled for all types
  • Explicitly handle SYMBOL and NULL
  • Also fixes a minor bug in stats collection which can cause NPE after query fails

@Jackie-Jiang Jackie-Jiang added bugfix cleanup multi-stage Related to the multi-stage query engine labels Jun 8, 2024
@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 June 8, 2024 05:58
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.81407% with 74 lines in your changes missing coverage. Please review.

Project coverage is 62.05%. Comparing base (59551e4) to head (908f611).
Report is 582 commits behind head on master.

Files Patch % Lines
...pache/pinot/common/utils/request/RequestUtils.java 52.30% 25 Missing and 6 partials ⚠️
.../planner/serde/ProtoExpressionToRexExpression.java 43.33% 16 Missing and 1 partial ⚠️
...inot/query/planner/logical/RexExpressionUtils.java 77.77% 5 Missing and 9 partials ⚠️
.../planner/serde/RexExpressionToProtoExpression.java 61.90% 7 Missing and 1 partial ⚠️
.../query/planner/logical/RelToPlanNodeConverter.java 0.00% 1 Missing and 2 partials ⚠️
...core/query/executor/ServerQueryExecutorV1Impl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #13344      +/-   ##
============================================
+ Coverage     61.75%   62.05%   +0.30%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2545     +109     
  Lines        133233   139720    +6487     
  Branches      20636    21675    +1039     
============================================
+ Hits          82274    86702    +4428     
- Misses        44911    46456    +1545     
- Partials       6048     6562     +514
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.02% <62.81%> (+0.31%) ⬆️
java-21 61.93% <62.81%> (+0.31%) ⬆️
skip-bytebuffers-false 62.04% <62.81%> (+0.29%) ⬆️
skip-bytebuffers-true 35.09% <62.81%> (+7.37%) ⬆️
temurin 62.05% <62.81%> (+0.30%) ⬆️
unittests 62.04% <62.81%> (+0.30%) ⬆️
unittests1 46.59% <62.81%> (-0.30%) ⬇️
unittests2 27.74% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang added the backward-incompat Referenced by PRs that introduce or fix backward compat issues label Jun 8, 2024
@Jackie-Jiang Jackie-Jiang force-pushed the fix_literal_type_handling branch from 8e26655 to 908f611 Compare June 8, 2024 08:36
@Jackie-Jiang Jackie-Jiang merged commit 1229add into apache:master Jun 8, 2024
@Jackie-Jiang Jackie-Jiang deleted the fix_literal_type_handling branch June 8, 2024 17:25
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
@Jackie-Jiang @gortiz
[Multi-stage] Fix literal handling (apache#13344)
6b7d64e
@npawar npawar added the v1v2 label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangfu0 xiangfu0 xiangfu0 approved these changes

Assignees

No one assigned

Labels

backward-incompat Referenced by PRs that introduce or fix backward compat issues bugfix cleanup multi-stage Related to the multi-stage query engine v1v2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jackie-Jiang @codecov-commenter @xiangfu0 @npawar