Skip to content

[multistage] Make window operator more resilient #13180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiangfu0 merged 2 commits into from
May 21, 2024
Merged

[multistage] Make window operator more resilient #13180

xiangfu0 merged 2 commits into from
May 21, 2024

Conversation

@xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented May 18, 2024 •
edited
Loading

  • Support window cache protection with a row based size limit
  • Add stats for window cache overflow

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.23077% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 62.24%. Comparing base (59551e4) to head (7dc9789).
Report is 465 commits behind head on master.

Files Patch % Lines
...uery/runtime/operator/WindowAggregateOperator.java 85.29% 0 Missing and 5 partials ⚠️
...common/response/broker/BrokerResponseNativeV2.java 0.00% 3 Missing ⚠️
...e/pinot/common/utils/config/QueryOptionsUtils.java 50.00% 0 Missing and 2 partials ⚠️
...not/query/runtime/operator/MultiStageOperator.java 0.00% 2 Missing ⚠️
...va/org/apache/pinot/spi/utils/CommonConstants.java 0.00% 2 Missing ⚠️
...t/common/response/broker/BrokerResponseNative.java 0.00% 1 Missing ⚠️
...pache/pinot/calcite/rel/hint/PinotHintOptions.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #13180      +/-   ##
============================================
+ Coverage     61.75%   62.24%   +0.49%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2527      +91     
  Lines        133233   138361    +5128     
  Branches      20636    21404     +768     
============================================
+ Hits          82274    86121    +3847     
- Misses        44911    45819     +908     
- Partials       6048     6421     +373
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.19% <69.23%> (+0.48%) ⬆️
java-21 62.13% <69.23%> (+0.50%) ⬆️
skip-bytebuffers-false 62.21% <69.23%> (+0.47%) ⬆️
skip-bytebuffers-true 62.11% <69.23%> (+34.38%) ⬆️
temurin 62.24% <69.23%> (+0.49%) ⬆️
unittests 62.23% <69.23%> (+0.49%) ⬆️
unittests1 46.76% <69.23%> (-0.13%) ⬇️
unittests2 27.92% <0.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang added feature documentation multi-stage Related to the multi-stage query engine labels May 18, 2024
@xiangfu0 xiangfu0 force-pushed the v2-window-op-protection branch from 07eca92 to 2fc8aec Compare May 19, 2024 04:25
@xiangfu0 xiangfu0 force-pushed the v2-window-op-protection branch from 2fc8aec to 7dc9789 Compare May 19, 2024 04:33
@xiangfu0 xiangfu0 merged commit 34a1fb7 into apache:master May 21, 2024
@xiangfu0 xiangfu0 deleted the v2-window-op-protection branch May 21, 2024 01:15
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
@xiangfu0 @gortiz
[multistage] Make window operator more resilient (apache#13180)
5b9a514 
* [multistage] Make window operator more resilient

* Adding stats
@yashmayya yashmayya added the window-functions Related to SQL window functions on the multi-stage query engine label Nov 26, 2024
@yashmayya yashmayya mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jackie-Jiang Jackie-Jiang Jackie-Jiang approved these changes

@gortiz gortiz Awaiting requested review from gortiz

@KKcorps KKcorps Awaiting requested review from KKcorps

Assignees

No one assigned

Labels

documentation feature multi-stage Related to the multi-stage query engine window-functions Related to SQL window functions on the multi-stage query engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiangfu0 @codecov-commenter @Jackie-Jiang @yashmayya