SQL compliance: allow INT and FLOAT literal #13078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #13078 +/- ##
============================================
+ Coverage 61.75% 62.13% +0.38%
+ Complexity 207 198 -9
============================================
Files 2436 2514 +78
Lines 133233 137871 +4638
Branches 20636 21328 +692
============================================
+ Hits 82274 85673 +3399
- Misses 44911 45790 +879
- Partials 6048 6408 +360
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
force-pushed
the
fix_int_float_literal
branch
from
41ada14 to
4a74fa9
Compare
Jackie-Jiang
added
the
backward-incompat
Jackie-Jiang
force-pushed
the
fix_int_float_literal
branch
3 times, most recently
from
b3e6c3a to
c47f8bc
Compare
Jackie-Jiang
force-pushed
the
fix_int_float_literal
branch
from
c47f8bc to
3182f6e
Compare
xiangfu0
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11763 we have added support to server to support both INT and FLOAT literal.
After one release (release 1.1), now we can move forward to send INT and FLOAT from broker side.
This PR also contains type related fixes and cleanups:
Literal.getFieldValue()because the field stored in thrift doesn't always reflect the actual Pinot value. Replaced with newly introduced helper functions inRequestUtilsBackward Incompatible
This PR can cause incompatibility for the new added
VECTOR_SIMILARITYfunction during upgrade. But since this feature is newly added and not in production, we won't wait another release to fix it