Add metrics to count joins and window functions #13032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13032 +/- ##
============================================
+ Coverage 61.75% 62.03% +0.28%
+ Complexity 207 198 -9
============================================
Files 2436 2540 +104
Lines 133233 139591 +6358
Branches 20636 21597 +961
============================================
+ Hits 82274 86601 +4327
- Misses 44911 46500 +1589
- Partials 6048 6490 +442
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
added
metrics
observability
multi-stage
Jackie-Jiang
approved these changes
May 20, 2024
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Please take a look at the failed tests
gortiz
force-pushed
the
join-metrics
branch
2 times, most recently
from
a2ca1c9 to
10c38b3
Compare
gortiz
added a commit
to gortiz/pinot
that referenced
this pull request
Jun 14, 2024
This PR adds 4 new metrics: * queriesWithJoins (global): How many queries with joins have been executed. For each query with at least one join, this meter is increased exactly once. * joinCount (global): How many joins have been executed. For each query with at least one join, this meter is increased as many times as joins in the query. * queriesWithWindow (global): How many queries with window functions have been executed. For each query with at least one window function, this meter is increased exactly once. * windowCount (global): How many window functions have been executed. For each query with at least one window function, this meter is increased as many times as window functions in the query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 4 new metrics: