Refactor PinotTaskManager class #12964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12964 +/- ##
============================================
+ Coverage 61.75% 62.20% +0.45%
+ Complexity 207 198 -9
============================================
Files 2436 2502 +66
Lines 133233 136503 +3270
Branches 20636 21128 +492
============================================
+ Hits 82274 84913 +2639
- Misses 44911 45318 +407
- Partials 6048 6272 +224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
There was a problem hiding this comment.
Suggest keeping the following APIs:
Map<String, List<String>> scheduleTasksForAllTables(@Nullable String minionInstanceTag)Map<String, List<String>> scheduleTasksForDatabase(@Nullable String database, @Nullable String minionInstanceTag)Map<String, List<String>> scheduleTasksForTable(String tableNameWithType, @Nullable String minionInstanceTag)List<String> scheduleTaskForAllTables(String taskType, @Nullable String minionInstanceTag)List<String> scheduleTaskForDatabase(String taskType, @Nullable String database, @Nullable String minionInstanceTag)List<String> scheduleTaskForTable(String taskType, String tableNameWithType, @Nullable String minionInstanceTag)
Jackie-Jiang
added
the
incompatible
tibrewalpratik17
force-pushed
the
fix_minion_scheduler
branch
from
70b3da8 to
8313729
Compare
Jackie-Jiang
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label:
refactorThe PinotTaskManager had a lot of
scheduleTaskmethods which was making it unreadable and hard to make changes as adding a new param needs to properly vetted throughout the code.This change leaves 6 public methods in the class:
The first 3 methods schedules all the tasks for given table / database / cluster. The next 3 methods, schedules the task type specified for database / tables / cluster.
This makes the code more readable and easy to use.