Schedule segments with higher invalidDocs first in Upsert Compaction task #12461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12461 +/- ##
============================================
+ Coverage 61.72% 61.77% +0.05%
Complexity 207 207
============================================
Files 2436 2436
Lines 133178 133185 +7
Branches 20628 20629 +1
============================================
+ Hits 82208 82281 +73
+ Misses 44923 44847 -76
- Partials 6047 6057 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label:
performanceThis patch sorts the candidate-segments for UpsertCompaction in descending order of invalidDocs present. This way we get more disk reduction if
tableMaxNumTasksis specified.Added UTs to verify the expected behaviour.