Deduping validDocIdsMetadata response #12445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12445 +/- ##
============================================
- Coverage 61.77% 61.73% -0.04%
Complexity 207 207
============================================
Files 2436 2436
Lines 133130 133134 +4
Branches 20623 20624 +1
============================================
- Hits 82241 82191 -50
- Misses 44850 44899 +49
- Partials 6039 6044 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
snleee
reviewed
Feb 20, 2024
| } | ||
| } | ||
|
|
||
| Map<String, ValidDocIdsMetadataInfo> dedupedValidDocIdsMapping = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
Instead of adding this, we can change validDocIdsMetadataInfos to Map<String, ValidDocIdsMetadataInfo>
Contributor
Author
There was a problem hiding this comment.
Sure let me do that!
Contributor
|
@tibrewalpratik17 can we combine the pr with #12431 ? |
Contributor
Author
|
@snleee closing this PR, will add all the changes in the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label:
bugfixCurrently, this endpoint
tables/{tableName}/validDocIdsMetadatareturns the validDocID metadata for the same segment multiple times (equal to number of replicas).This causes issues with UpsertCompaction task too as the same segment starts getting processed multiple times (for deletion / compaction).
This patch dedupes the response of the API itself which is implicitly used by UpsertCompactionTaskGenerator too.