Fix bug to return validDocIDsMetadata from all servers #12431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12431 +/- ##
============================================
- Coverage 61.77% 61.75% -0.02%
Complexity 207 207
============================================
Files 2436 2436
Lines 133130 133176 +46
Branches 20623 20632 +9
============================================
+ Hits 82241 82246 +5
- Misses 44850 44890 +40
- Partials 6039 6040 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ankitsultana
approved these changes
Feb 15, 2024
Contributor
ankitsultana
left a comment
ankitsultana
left a comment
There was a problem hiding this comment.
Good catch. @tibrewalpratik17 : can you also add what was the impact of this bug in the description?
Contributor
Author
|
@snleee can you take a look at this fix for the tagged issue? |
Contributor
|
@tibrewalpratik17 can we combine this pr with #12445? |
tibrewalpratik17
force-pushed
the
fix_uc_bug
branch
from
4dbfd51 to
c987ff1
Compare
snleee
approved these changes
Feb 20, 2024
Contributor
snleee
left a comment
snleee
left a comment
There was a problem hiding this comment.
LGTM! Thanks for catching the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label:
bugfixFixes #12423
We were sending
serverToEndpointsmapping instead ofendpointsToServerwhich is expected by CompletionService. That's why CompletionService was always returning 1 server's response as it was having null as the only key in map and returning response of the last server it receives overwriting the response of previous server(s) always.The impact of this bug was that getValidDocIdMetadata endpoint was always returning results from one server instead of the number of servers the table is actually hosted on. This affects UpsertCompaction task too as it now processes the segments of any 1 random server at a time instead of all.
Another bug fix from #12445
Currently, this endpoint
tables/{tableName}/validDocIdsMetadatareturns the validDocID metadata for the same segment multiple times (equal to number of replicas).This causes issues with UpsertCompaction task too as the same segment starts getting processed multiple times (for deletion / compaction).
This patch dedupes the response of the API itself which is implicitly used by UpsertCompactionTaskGenerator too.