[Multi-stage] Fix SortedMailboxReceiveOperator to not pull 2 EOS blocks #12406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12406 +/- ##
============================================
+ Coverage 61.70% 61.72% +0.02%
Complexity 207 207
============================================
Files 2428 2428
Lines 132823 132823
Branches 20544 20544
============================================
+ Hits 81958 81989 +31
+ Misses 44846 44822 -24
+ Partials 6019 6012 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangfu0
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
SortedMailboxReceiveOperatorwill always pull 2 EOS blocks from underlying mailboxes, which doesn't follow the convention. This PR fixes it by caching the first EOS block so that it can be returned in the nextgetNextBlock()