Skip to content

Conversation

@Jackie-Jiang
Copy link
Contributor

It is not captured by test because stage id is only for logging and debugging purpose

@Jackie-Jiang Jackie-Jiang added bugfix multi-stage Related to the multi-stage query engine labels Feb 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a5a134) 61.73% compared to head (63dbbcd) 61.58%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12366      +/-   ##
============================================
- Coverage     61.73%   61.58%   -0.16%     
  Complexity      207      207              
============================================
  Files          2426     2426              
  Lines        132675   132677       +2     
  Branches      20506    20506              
============================================
- Hits          81908    81707     -201     
- Misses        44752    44965     +213     
+ Partials       6015     6005      -10     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 27.68% <0.00%> (-33.96%) ⬇️
java-21 61.57% <100.00%> (-0.05%) ⬇️
skip-bytebuffers-false 61.56% <100.00%> (-0.15%) ⬇️
skip-bytebuffers-true 61.54% <100.00%> (-0.02%) ⬇️
temurin 61.58% <100.00%> (-0.16%) ⬇️
unittests 61.57% <100.00%> (-0.16%) ⬇️
unittests1 46.75% <100.00%> (-0.17%) ⬇️
unittests2 27.69% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 96c3bf2 into apache:master Feb 5, 2024
@Jackie-Jiang Jackie-Jiang deleted the fix_stage_id branch February 5, 2024 18:34
suyashpatel98 pushed a commit to suyashpatel98/pinot that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants