Skip to content

Conversation

@Jackie-Jiang
Copy link
Contributor

Making stage plan serialization (on broker) and deserialization (on server) execute in parallel

@Jackie-Jiang Jackie-Jiang added enhancement multi-stage Related to the multi-stage query engine labels Feb 3, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there're some issues with submission stub NPE. PTAL

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c9a82c4) 61.68% compared to head (7b80861) 61.69%.
Report is 1 commits behind head on master.

Files Patch % Lines
...apache/pinot/query/service/server/QueryServer.java 81.25% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12363      +/-   ##
============================================
+ Coverage     61.68%   61.69%   +0.01%     
- Complexity      207     1155     +948     
============================================
  Files          2426     2426              
  Lines        132674   132675       +1     
  Branches      20502    20506       +4     
============================================
+ Hits          81838    81859      +21     
+ Misses        44832    44802      -30     
- Partials       6004     6014      +10     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.64% <90.76%> (+<0.01%) ⬆️
java-21 61.57% <90.76%> (+0.01%) ⬆️
skip-bytebuffers-false 61.66% <90.76%> (-0.01%) ⬇️
skip-bytebuffers-true 61.56% <90.76%> (+0.01%) ⬆️
temurin 61.69% <90.76%> (+0.01%) ⬆️
unittests 61.69% <90.76%> (+0.01%) ⬆️
unittests1 46.88% <90.76%> (-0.01%) ⬇️
unittests2 27.71% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang force-pushed the parallel_deserialize_query_plan branch from f623eb4 to 7b80861 Compare February 4, 2024 02:12
@Jackie-Jiang Jackie-Jiang merged commit 0a5a134 into apache:master Feb 4, 2024
@Jackie-Jiang Jackie-Jiang deleted the parallel_deserialize_query_plan branch February 4, 2024 19:20
suyashpatel98 pushed a commit to suyashpatel98/pinot that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants