Implement IN and NOT_IN filters in FilterOperand class (#12285 fix) #12305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix) Added IN and NOT_IN cases to the FilterOperand class and TransformOperandFactory classes. The PR is related to the 12285 bug: using of the IN expression in the CASE statement within the projection part of the SELECT multistage query. When this expression is used, the query execution fails with an IllegalStateException error, indicating that the function IN cannot be found.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12305 +/- ##
=============================================
- Coverage 61.51% 34.62% -26.90%
+ Complexity 1147 951 -196
=============================================
Files 2417 2341 -76
Lines 131584 127857 -3727
Branches 20314 19765 -549
=============================================
- Hits 80939 44265 -36674
- Misses 44716 80426 +35710
+ Partials 5929 3166 -2763
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
walterddr
reviewed
Jan 22, 2024
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
thank you sir for the fix. could you add some test cases to
pinot-query-runtime/src/test/resources/queries/Case.json ?
Jackie-Jiang
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12285, #12305
Added IN and NOT_IN cases to the FilterOperand class and TransformOperandFactory classes. The PR is related to the 12285 bug: using of the IN expression in the CASE statement within the projection part of the SELECT multistage query. When this expression is used, the query execution fails with an IllegalStateException error, indicating that the function IN cannot be found.