[multistage][bugfix] relax sort copy rule to always push limit if no collation #12251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
walterddr
force-pushed
the
fix_sort_non_collation_limit_push
branch
from
79b0aa9 to
eb1d883
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12251 +/- ##
============================================
+ Coverage 61.38% 61.56% +0.18%
- Complexity 1152 1153 +1
============================================
Files 2416 2416
Lines 131198 131205 +7
Branches 20249 20250 +1
============================================
+ Hits 80531 80781 +250
+ Misses 44767 44532 -235
+ Partials 5900 5892 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
further improve on #12228
in addition to #12237, this change relaxes to always pushdown when non-collation limit exists. therefore the configuration of pushdown limit no longer needs to be configurable until long-term impl is in place.