[multistage]Fix chained literal functions evaluation #12248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
changed the title
xiangfu0
force-pushed
the
fixing-literal-evaluation
branch
3 times, most recently
from
6f28d39 to
3473fba
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12248 +/- ##
============================================
- Coverage 61.58% 61.56% -0.02%
- Complexity 1152 1153 +1
============================================
Files 2415 2415
Lines 131476 131476
Branches 20303 20303
============================================
- Hits 80963 80945 -18
- Misses 44597 44613 +16
- Partials 5916 5918 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
walterddr
reviewed
Jan 11, 2024
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
looks like the integration test error is legit. can we take a look?
xiangfu0
force-pushed
the
fixing-literal-evaluation
branch
from
3473fba to
56df27e
Compare
Contributor
Author
yes, there is a missing check for cast and generate_array method catches it. Will follow up another PR to support compile time all literal function evaluation when the return type is array. |
walterddr
approved these changes
Jan 12, 2024
walterddr
reviewed
Jan 12, 2024
pinot-query-planner/src/test/resources/queries/LiteralEvaluationPlans.json
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
fixing-literal-evaluation
branch
from
56df27e to
66b015a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #12245