[multistage][hotfix] use UTF-8 as default CharSet, this is also true for v1 engine #12213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterddr
force-pushed
the
hotfix_default_charset
branch
from
e3ee0b9 to
05f48dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12213 +/- ##
============================================
+ Coverage 61.51% 61.55% +0.04%
Complexity 1153 1153
============================================
Files 2415 2416 +1
Lines 131157 131177 +20
Branches 20245 20245
============================================
+ Hits 80683 80751 +68
+ Misses 44575 44523 -52
- Partials 5899 5903 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
reviewed
Jan 3, 2024
| * upgrading Calcite versions. | ||
| */ | ||
| public class TypeFactory extends JavaTypeFactoryImpl { | ||
| private static final Charset DEFAULT_CHARSET = StandardCharsets.UTF_8; |
Contributor
There was a problem hiding this comment.
is there anyway to set default charset?
Contributor
Author
There was a problem hiding this comment.
this is the way to set the default charset (e.g. via overriding typeFactory).
xiangfu0
approved these changes
Jan 3, 2024
Contributor
xiangfu0
left a comment
xiangfu0
left a comment
There was a problem hiding this comment.
Please add a PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinot uses UTF-8 as the default encoding so we should follow the same for V2 engine