Skip to content

[multistage][refactor] clean up planner #12070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
walterddr merged 3 commits into from
Nov 29, 2023
Merged

[multistage][refactor] clean up planner #12070

walterddr merged 3 commits into from
Nov 29, 2023

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Nov 29, 2023 •
edited
Loading

  • plan fragment metadata is not needed, we use dispatchablePlanFragment & dispatchablePlanMetadata
  • move Dispatchable* class into physical package
  • move Explain in to explain package

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c57117a) 0.00% compared to head (7a8a2a9) 61.60%.

Additional details and impacted files 
@@              Coverage Diff              @@
##             master   #12070       +/-   ##
=============================================
+ Coverage      0.00%   61.60%   +61.59%     
- Complexity        6     1153     +1147     
=============================================
  Files          2314     2389       +75     
  Lines        126078   129819     +3741     
  Branches      19524    20082      +558     
=============================================
+ Hits              6    79970    +79964     
+ Misses       126072    44025    -82047     
- Partials          0     5824     +5824
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (?)
integration2 0.00% <0.00%> (?)
java-11 61.57% <100.00%> (+61.56%) ⬆️
java-21 34.88% <100.00%> (+34.88%) ⬆️
skip-bytebuffers-false 61.59% <100.00%> (?)
skip-bytebuffers-true 34.87% <100.00%> (?)
temurin 61.60% <100.00%> (+61.59%) ⬆️
unittests 61.59% <100.00%> (?)
unittests1 46.88% <100.00%> (?)
unittests2 27.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walterddr walterddr marked this pull request as ready for review November 29, 2023 20:54
@walterddr walterddr merged commit b9ed378 into apache:master Nov 29, 2023
@Jackie-Jiang Jackie-Jiang added cleanup multi-stage Related to the multi-stage query engine labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangfu0 xiangfu0 xiangfu0 approved these changes

Assignees

No one assigned

Labels

cleanup multi-stage Related to the multi-stage query engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@walterddr @codecov-commenter @xiangfu0 @Jackie-Jiang