[multistage] don't prune project after agg during relBuilder #12058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12058 +/- ##
============================================
+ Coverage 61.62% 61.63% +0.01%
- Complexity 1151 1152 +1
============================================
Files 2386 2386
Lines 129567 129580 +13
Branches 20053 20056 +3
============================================
+ Hits 79847 79871 +24
+ Misses 43913 43895 -18
- Partials 5807 5814 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
walterddr
changed the title
Jackie-Jiang
approved these changes
Nov 29, 2023
Comment on lines
124
to
+126
| .addRelBuilderConfigTransform(c -> c.withPushJoinCondition(true)) | ||
| .addRelBuilderConfigTransform(c -> c.withAggregateUnique(true))) | ||
| .addRelBuilderConfigTransform(c -> c.withAggregateUnique(true)) | ||
| .addRelBuilderConfigTransform(c -> c.withPruneInputOfAggregate(false))) |
Contributor
There was a problem hiding this comment.
(minor) Can we chain them as .addRelBuilderConfigTransform(c -> c.withPushJoinCondition(true).withAggregateUnique(true).withPruneInputOfAggregate(false))?
Contributor
Author
There was a problem hiding this comment.
good point. just saw this, will clean up later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we already have agg-project merge rule. no need to do it during relbuilder. which might cause eliminating project useful for other rules.
this fix #12013