Fixing dateTimeConvert regression #11971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snleee
approved these changes
Nov 8, 2023
Contributor
snleee
left a comment
snleee
left a comment
There was a problem hiding this comment.
wow, thanks for the quick fix! LGTM
xiangfu0
force-pushed
the
fixing-dateTimeConvert
branch
from
34cd639 to
5c57c33
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11971 +/- ##
============================================
- Coverage 61.43% 61.41% -0.02%
Complexity 207 207
============================================
Files 2385 2385
Lines 129149 129150 +1
Branches 19994 19994
============================================
- Hits 79342 79318 -24
- Misses 44055 44075 +20
- Partials 5752 5757 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
approved these changes
Nov 8, 2023
xiangfu0
force-pushed
the
fixing-dateTimeConvert
branch
from
5c57c33 to
5ea37e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing the regression introduced from: #11839