Skip to content

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Nov 8, 2023

  • optimized query physical plan to omit all mailbox
    • non-leaf will also get omit
    • multiple worker within a server will also get omit
    • all places with contextual info are now
      • printed as the following format: <PREFIX>[<FRAGMENT_ID>]@<HOSTNAME>:<PORT>|[<WORKER_ID>],
      • with multiple instances of the context, the format will be wrapped in { and } in a comma-separated list.
...
              └── [1]@localhost:1|[1] PROJECT
                  └── [1]@localhost:1|[1] JOIN
                      ├── [1]@localhost:1|[1] MAIL_RECEIVE(HASH_DISTRIBUTED)
                      │   ├── [2]@localhost:2|[2] MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:2|[2, 3],[1]@localhost:1|[0, 1]} (Subtree Omitted)
                      │   ├── [2]@localhost:2|[3] MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:2|[2, 3],[1]@localhost:1|[0, 1]} (Subtree Omitted)
...
  • support other plan parsing in ResourceBasedQueryPlansTest
    • regex replace supported feature such as AS ..., ...ATTRIBUTES
    • WITH ... is not supported as we don't actually have corresponding processing on this variance yet.

This also addresses the verbose issue of subtree omit in #11272

@walterddr walterddr force-pushed the pr_test_enhance_plan_test branch from 135c4c7 to bd038c3 Compare November 8, 2023 00:26
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.29%. Comparing base (45f1869) to head (bd038c3).
⚠️ Report is 2996 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11966      +/-   ##
============================================
- Coverage     61.43%   61.29%   -0.15%     
- Complexity     1135     1141       +6     
============================================
  Files          2385     2385              
  Lines        129150   129149       -1     
  Branches      19994    19994              
============================================
- Hits          79347    79164     -183     
- Misses        44049    44237     +188     
+ Partials       5754     5748       -6     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 27.60% <0.00%> (-33.78%) ⬇️
java-21 61.29% <100.00%> (-0.02%) ⬇️
skip-bytebuffers-false 61.27% <100.00%> (-0.14%) ⬇️
skip-bytebuffers-true 61.26% <100.00%> (-0.03%) ⬇️
temurin 61.29% <100.00%> (-0.15%) ⬇️
unittests 61.29% <100.00%> (-0.15%) ⬇️
unittests1 46.50% <100.00%> (-0.17%) ⬇️
unittests2 27.59% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@walterddr walterddr merged commit b5e9823 into apache:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants