Support constant filter in QueryContext, and make server able to handle it #11956
Conversation
Jackie-Jiang
added
enhancement
multi-stage
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11956 +/- ##
============================================
- Coverage 61.45% 61.40% -0.05%
+ Complexity 1145 207 -938
============================================
Files 2385 2385
Lines 129065 129137 +72
Branches 19955 19991 +36
============================================
- Hits 79317 79301 -16
- Misses 44023 44083 +60
- Partials 5725 5753 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
lgtm mostly. minor questions
|
|
||
| @Test | ||
| void testDeduplicateOrderByExpressions() { | ||
| public void testDeduplicateOrderByExpressions() { |
| case LITERAL: | ||
| // TODO: Handle literals. | ||
| throw new IllegalStateException(); | ||
| return FilterContext.forConstant(new LiteralContext(thriftExpression.getLiteral()).getBooleanValue()); |
There was a problem hiding this comment.
general question: why do we need to repeat ourselves on these utils one for thrift and one for function context?
it looks like the only difference is one is for WHERE and one is for HAVING?
There was a problem hiding this comment.
One is used in aggregation FILTER where the expression is already parsed into context format
3 participants
Currently we rely on broker to remove the constant (true/false) filter, and server doesn't support processing constant filter. This PR adds the server side support to handle constant filter which is needed for multi-stage engine as leaf stage