[bugfix] Agg literal attach should happen after BASIC_RULES #11863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
approved these changes
Oct 23, 2023
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Please add a test for this
Codecov Report
@@ Coverage Diff @@
## master #11863 +/- ##
============================================
- Coverage 62.99% 62.83% -0.17%
Complexity 1140 1140
============================================
Files 2343 2367 +24
Lines 126305 127943 +1638
Branches 19419 19744 +325
============================================
+ Hits 79563 80388 +825
- Misses 41071 41826 +755
- Partials 5671 5729 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 149 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #11862