Log query and emit metrics for grpc request and multi-stage leaf stage #11838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
enhancement
release-notes
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11838 +/- ##
============================================
- Coverage 66.35% 66.29% -0.07%
Complexity 207 207
============================================
Files 2350 2351 +1
Lines 127281 127310 +29
Branches 19603 19606 +3
============================================
- Hits 84463 84397 -66
- Misses 36924 37031 +107
+ Partials 5894 5882 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
force-pushed
the
grpc_query_log
branch
from
11b432a to
4b05e5a
Compare
xiangfu0
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerQueryLoggernumResizesinto prometheus configresizeTimeMsto be a meter instead of gaugepinot.server.query.log.maxRatePerSecondto replace the deprecatedpinot.query.scheduler.query.log.maxRatePerSecond(backward compatible)pinot.server.query.log.droppedReportMaxRatePerSecondto configure the dropped log report frequencyRelease Notes
New config added for server:
pinot.server.query.log.maxRatePerSecond: query log max rate (QPS, default 10K)pinot.server.query.log.droppedReportMaxRatePerSecond: dropped query log report max rate (QPS, default 1)