Skip to content

Conversation

@walterddr
Copy link
Contributor

adding the missing test cases for dash/dot column naming and table escapes
we use to only have quoted identifier tests on LexicalStructure test cases but only on columns.

@walterddr walterddr marked this pull request as ready for review October 4, 2023 16:09
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #11737 (ef93fbc) into master (78fc66b) will decrease coverage by 0.03%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11737      +/-   ##
============================================
- Coverage     63.12%   63.09%   -0.03%     
  Complexity     1118     1118              
============================================
  Files          2342     2342              
  Lines        125889   125919      +30     
  Branches      19360    19362       +2     
============================================
- Hits          79462    79450      -12     
- Misses        40783    40821      +38     
- Partials       5644     5648       +4     
Flag Coverage Δ
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.07% <ø> (+<0.01%) ⬆️
java-17 62.94% <ø> (-0.04%) ⬇️
java-20 62.95% <ø> (-0.01%) ⬇️
temurin 63.09% <ø> (-0.03%) ⬇️
unittests 63.09% <ø> (-0.03%) ⬇️
unittests1 67.23% <ø> (-0.06%) ⬇️
unittests2 14.43% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr merged commit 7ed9aa3 into apache:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants