Skip to content

[multistage][test] add ignored test capability #11703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
walterddr merged 1 commit into from
Sep 28, 2023
Merged

[multistage][test] add ignored test capability #11703

walterddr merged 1 commit into from
Sep 28, 2023

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Sep 28, 2023

  • add flag to run ignored tests cases
    • doesn't support run ignored tables b/c we can't load those table during setUp
  • fix several ignored where we already supports now.

@walterddr walterddr added testing multi-stage Related to the multi-stage query engine labels Sep 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.08%. Comparing base (1f93870) to head (15b3415).
⚠️ Report is 3283 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #11703      +/-   ##
============================================
- Coverage     63.10%   63.08%   -0.02%     
+ Complexity     1120     1118       -2     
============================================
  Files          2343     2342       -1     
  Lines        125672   125667       -5     
  Branches      19317    19319       +2     
============================================
- Hits          79309    79281      -28     
- Misses        40705    40728      +23     
  Partials       5658     5658
Flag Coverage Δ
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.03% <ø> (-0.03%) ⬇️
java-17 62.91% <ø> (-0.02%) ⬇️
java-20 62.95% <ø> (+0.01%) ⬆️
temurin 63.08% <ø> (-0.02%) ⬇️
unittests 63.08% <ø> (-0.02%) ⬇️
unittests1 67.22% <ø> (-0.01%) ⬇️
unittests2 14.47% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@walterddr walterddr merged commit 15988f6 into apache:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jackie-Jiang Jackie-Jiang Jackie-Jiang approved these changes

Assignees

No one assigned

Labels

multi-stage Related to the multi-stage query engine testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@walterddr @codecov-commenter @Jackie-Jiang