[multistage] improve dispatch exception handling #11688
Conversation
walterddr
force-pushed
the
fix_exception_handling
branch
from
782d9e6 to
664f363
Compare
There was a problem hiding this comment.
This is no longer a service. IMO it might be more readable if we directly implement this logic in QueryServer.submit(). I don't really see the value of this wrapper class
There was a problem hiding this comment.
good point. will convert it into a util --> its only job is to maintain the list of futures for completion (wrapper class will make it easy to retest the logic IMO)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11688 +/- ##
============================================
- Coverage 63.10% 63.03% -0.07%
+ Complexity 1121 1118 -3
============================================
Files 2343 2342 -1
Lines 125693 125663 -30
Branches 19310 19318 +8
============================================
- Hits 79315 79217 -98
- Misses 40728 40796 +68
Partials 5650 5650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Can this ever throw Throwable? Or is it always wrapped in ExecutionException?
There was a problem hiding this comment.
it shouldn't be but it would be hell of a pain to debug if it did. so just to keep it safe. we should at least have a branch to handle it
walterddr
force-pushed
the
fix_exception_handling
branch
from
1dcf3d5 to
6b53ef1
Compare
walterddr
force-pushed
the
fix_exception_handling
branch
from
6b53ef1 to
766c8c3
Compare
3 participants
QueryServer/QueryDispatcherwhich is the center of the dispatch/server pair