Skip to content

In multi-stage aggregate, directly store column index as identifier #11617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jackie-Jiang merged 2 commits into from
Sep 19, 2023
Merged

In multi-stage aggregate, directly store column index as identifier #11617

Jackie-Jiang merged 2 commits into from
Sep 19, 2023

Conversation

@Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Sep 18, 2023

Avoid constructing the column name to index map and converting back and forth

@Jackie-Jiang Jackie-Jiang added enhancement multi-stage Related to the multi-stage query engine labels Sep 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.71875% with 17 lines in your changes missing coverage. Please review.

Project coverage is 63.05%. Comparing base (fa51477) to head (8c91320).
Report is 2792 commits behind head on master.

Files with missing lines Patch % Lines
...inot/query/runtime/operator/AggregateOperator.java 82.29% 8 Missing and 9 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #11617      +/-   ##
============================================
- Coverage     63.08%   63.05%   -0.04%     
- Complexity     1106     1109       +3     
============================================
  Files          2326     2326              
  Lines        124942   124956      +14     
  Branches      19147    19152       +5     
============================================
- Hits          78821    78785      -36     
- Misses        40499    40549      +50     
  Partials       5622     5622
Flag Coverage Δ
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 63.02% <86.71%> (-0.02%) ⬇️
java-17 62.91% <86.71%> (+<0.01%) ⬆️
java-20 62.90% <86.71%> (-0.03%) ⬇️
temurin 63.05% <86.71%> (-0.04%) ⬇️
unittests 63.04% <86.71%> (-0.04%) ⬇️
unittests1 67.27% <86.71%> (-0.04%) ⬇️
unittests2 14.48% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

walterddr
walterddr approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. minor comment

...t-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java Outdated
Copy link
Contributor

@walterddr walterddr Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intermediate agg always have 1 real-argument (it cannot even be 0 b/c count would've been converted to SUM), and the rest are placeholders, why do we need to check the numArguments again here? simply do the loop with for (int i = 1 ... should be suffice?

Copy link
Contributor Author

@Jackie-Jiang Jackie-Jiang Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separated the code path for raw input vs intermediate input

@Jackie-Jiang Jackie-Jiang merged commit 987ebc0 into apache:master Sep 19, 2023
@Jackie-Jiang Jackie-Jiang deleted the aggregate_pass_index branch September 19, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterddr walterddr walterddr approved these changes

Assignees

No one assigned

Labels

enhancement multi-stage Related to the multi-stage query engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jackie-Jiang @codecov-commenter @walterddr