Log warning when multi-stage engine planning throws exception #11595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
enhancement
multi-stage
walterddr
approved these changes
Sep 14, 2023
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
there are some other places in BaseBrokerRequestHandler that also log info after catching exceptions we can revisit later i suppose
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11595 +/- ##
============================================
- Coverage 63.05% 63.04% -0.02%
Complexity 1106 1106
============================================
Files 2326 2326
Lines 124974 124974
Branches 19078 19078
============================================
- Hits 78803 78789 -14
- Misses 40569 40577 +8
- Partials 5602 5608 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We usually log
infoon query parsing because that indicates user error. For multi-stage planning, exception could indicate some state mismatch, so logwarnis more appropriate