Support up to 15 boolean expressions for casewhen scalar function #11566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11566 +/- ##
============================================
+ Coverage 62.94% 63.10% +0.15%
- Complexity 1106 1109 +3
============================================
Files 2325 2325
Lines 124772 124777 +5
Branches 19052 19052
============================================
+ Hits 78534 78736 +202
+ Misses 40625 40439 -186
+ Partials 5613 5602 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 31 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
lgtm. can we add a test?
snleee
force-pushed
the
support-larger-case-when-statements
branch
from
48f2d6b to
d23ee17
Compare
|
@walterddr Added the test. |
snleee
force-pushed
the
support-larger-case-when-statements
branch
from
d23ee17 to
3610386
Compare
snleee
changed the title
Current implementation supports up to 5 boolean expressions. This improves to support up to 15 expressions.
snleee
force-pushed
the
support-larger-case-when-statements
branch
from
3610386 to
ee51f5a
Compare
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
This is so ugly, but no easy solution lol..
Should we also add support for case-when without else?
|
The use case that I faced needs the else statement. If we don't cover else, we need to tweak by setting |
|
@snleee When else is not configured, we should just return |
4 participants
Current implementation supports up to 5 boolean expressions. This improves to support up to 15 expressions.