Null support for protobuf ingestion. #11553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenyu0127
force-pushed
the
protobuf-ingestion
branch
from
b172d36 to
00fc32a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11553 +/- ##
============================================
- Coverage 63.05% 63.04% -0.02%
+ Complexity 1109 1108 -1
============================================
Files 2320 2320
Lines 124667 124670 +3
Branches 19033 19033
============================================
- Hits 78614 78601 -13
- Misses 40458 40472 +14
- Partials 5595 5597 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangfu0
approved these changes
Sep 10, 2023
Contributor
|
Please add a release notes section for this. |
xiangfu0
added
release-notes
Contributor
Author
Done. |
Contributor
|
Thanks! |
swaminathanmanish
pushed a commit
to swaminathanmanish/pinot
that referenced
this pull request
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the protobuf field is NULL, we want to ingest the field as NULL.
Release-notes
Null support for protobuf ingestion: if the protobuf field is NULL, ingest the field as NULL.