Stream leaf stage blocks #11472
Merged
Stream leaf stage blocks #11472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
enhancement
documentation
incompatible
Jackie-Jiang
force-pushed
the
multi_stage_stream
branch
from
cc44b9a to
b6ad16e
Compare
Codecov Report
@@ Coverage Diff @@
## master #11472 +/- ##
============================================
- Coverage 62.95% 62.91% -0.04%
- Complexity 1098 1106 +8
============================================
Files 2319 2320 +1
Lines 124404 124476 +72
Branches 18996 19004 +8
============================================
- Hits 78316 78313 -3
- Misses 40514 40568 +54
- Partials 5574 5595 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
force-pushed
the
multi_stage_stream
branch
3 times, most recently
from
544838f to
4aa19e5
Compare
Jackie-Jiang
force-pushed
the
multi_stage_stream
branch
9 times, most recently
from
8145adb to
3ea2af3
Compare
xiangfu0
reviewed
Sep 1, 2023
Contributor
There was a problem hiding this comment.
Does it make sense to put queryContext into BaseResultsBlock with a constructor and use super here?
Contributor
Author
There was a problem hiding this comment.
I considered that, but it doesn't apply to metadata and exception block, so I kept it only in data blocks
xiangfu0
approved these changes
Sep 1, 2023
Jackie-Jiang
force-pushed
the
multi_stage_stream
branch
from
3ea2af3 to
aebffec
Compare
Jackie-Jiang
force-pushed
the
multi_stage_stream
branch
from
aebffec to
f536386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation
Added new query option
maxStreamingPendingBlocksto control the pending blocks for streaming (back pressure, 100 by default)Incompatible
The following interface changed: