[Multi-stage] Remove PhysicalPlanContext and clean up op-chain executor logic #11439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jackie-Jiang
commented
Aug 25, 2023
Jackie-Jiang
commented
- Remove PhysicalPlanContext and use OpChainExecutionContext instead
- Add request metadata in OpChainExecutionContext
- Clean up unused fields
Codecov Report
@@ Coverage Diff @@
## master #11439 +/- ##
============================================
- Coverage 62.99% 62.96% -0.03%
+ Complexity 1107 1094 -13
============================================
Files 2303 2302 -1
Lines 124041 123988 -53
Branches 18895 18894 -1
============================================
- Hits 78137 78073 -64
- Misses 40352 40359 +7
- Partials 5552 5556 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
force-pushed
the
remove_physical_plan_context
branch
from
f73d486 to
653cf20
Compare
Jackie-Jiang
force-pushed
the
remove_physical_plan_context
branch
from
653cf20 to
d50d6d6
Compare
xiangfu0
approved these changes
Aug 26, 2023
walterddr
added a commit
that referenced
this pull request
Nov 13, 2023
) currently pinotQuery only supports limited amount of PlanNodes this means an Exchange must be inserted in order to ensure the leaf stage can be converted into a PinotQuery. However this is a misuse of Exchange This PR plans to split the ServerRequest planning into 2 stages - first plan as much as possible into PinotQuery - for any remainder nodes that cannot be planned into PinotQuery, will be run together with the LeafStageTransferrableBlockOperator as the input locally. This PR also follows up with the refactoring from #11439. - removed server plan request context entirely and replace it with fields used by server side. - extends OpChainExecutionContext with additional info from ServerOpChainExecutionContext - break down steps from ServerPlanRequestUtils.build method into 3 parts --> - compile pinot query - convert pinot query into instance requests (based on physical segments) - construct an OpChain that sits on top Context: alternative PR to #11843 --------- Co-authored-by: Rong Rong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.