[multistage] Evaluate literal expression during query parsing #11438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
early-evaluate-literal
branch
3 times, most recently
from
8d0f568 to
b3b06f4
Compare
xiangfu0
changed the title
xiangfu0
force-pushed
the
early-evaluate-literal
branch
from
b3b06f4 to
2948236
Compare
Codecov Report
@@ Coverage Diff @@
## master #11438 +/- ##
============================================
- Coverage 63.04% 63.03% -0.02%
Complexity 1109 1109
============================================
Files 2320 2320
Lines 124477 124520 +43
Branches 19004 19011 +7
============================================
+ Hits 78477 78487 +10
- Misses 40417 40436 +19
- Partials 5583 5597 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
force-pushed
the
early-evaluate-literal
branch
from
e56efba to
2cdc4ba
Compare
xiangfu0
force-pushed
the
early-evaluate-literal
branch
10 times, most recently
from
a840b8a to
75ff297
Compare
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
We should not rely on type inference. Instead, we should use the standard bytes literal in SQL. Since this evaluator is on broker side, it shouldn't hit the limitation of v1 engine where bytes literal cannot be passed through thrift
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
early-evaluate-literal
branch
3 times, most recently
from
52a6817 to
d023fd8
Compare
xiangfu0
force-pushed
the
early-evaluate-literal
branch
5 times, most recently
from
1a527cd to
a5e63e6
Compare
xiangfu0
force-pushed
the
early-evaluate-literal
branch
8 times, most recently
from
fecc836 to
e7b1090
Compare
pinot-query-planner/src/test/resources/queries/LiteralEvaluationPlans.json
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java
Outdated
Show resolved
Hide resolved
...ntegration-tests/src/test/java/org/apache/pinot/integration/tests/custom/GeoSpatialTest.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
early-evaluate-literal
branch
2 times, most recently
from
88586bf to
c26e44e
Compare
Jackie-Jiang
approved these changes
Sep 2, 2023
pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/test/resources/queries/LiteralEvaluationPlans.json
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
early-evaluate-literal
branch
from
afbe77e to
fa6330a
Compare
xiangfu0
force-pushed
the
early-evaluate-literal
branch
from
fa6330a to
71440b5
Compare
walterddr
reviewed
Oct 3, 2023
| case STRINGFIELD: | ||
| return literalField.getStringField(); | ||
| case BYTESFIELD: | ||
| return literalField.getBytesField(); |
Contributor
There was a problem hiding this comment.
should unwrap ByteString here
walterddr
reviewed
Oct 3, 2023
Comment on lines
+152
to
+153
| } else if (fieldObject instanceof GregorianCalendar) { | ||
| builder.setLiteralField(longField(((GregorianCalendar) fieldObject).getTimeInMillis())); |
Contributor
There was a problem hiding this comment.
should not use longField b/c we cannot differentiate whether it is a long or a Calendar object when DeSer
walterddr
reviewed
Oct 3, 2023
| return expression; | ||
| } | ||
|
|
||
| public static Expression getLiteralExpression(ByteString value) { |
Contributor
There was a problem hiding this comment.
this is not necessary once we fixed ProtoSerdeUtils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use rule to evaluate and replace RexCall to RexLiteral in Project and Filter nodes.
The evaluation is recursive, so it will cover nested function calls as well.
Drawback: The FunctionInvoker is using v1 ScalarFunctions, so the data type output might be different than the RexNode type. In that case, we need to cast.