Add new broker query point for querying multi-stage engine #11341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
11251-create-a-separated-query-endpoint-for-multi-stage-query-engine
branch
from
2c08ee3 to
0379ba5
Compare
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
11251-create-a-separated-query-endpoint-for-multi-stage-query-engine
branch
from
0379ba5 to
1e614e2
Compare
Jackie-Jiang
approved these changes
Aug 14, 2023
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Seems there is a bug in MultiStageBrokerRequestHandler where it uses TRACE in the json request instead of the query options. We should use the one in query options instead. RequestUtils.setOptions() already set the one in json request into the query options.
Other than that, LGTM
Codecov Report
@@ Coverage Diff @@
## master #11341 +/- ##
============================================
- Coverage 68.46% 68.31% -0.16%
+ Complexity 6535 6532 -3
============================================
Files 2233 2233
Lines 119952 119971 +19
Branches 18191 18191
============================================
- Hits 82128 81955 -173
- Misses 31984 32171 +187
- Partials 5840 5845 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 31 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
force-pushed
the
11251-create-a-separated-query-endpoint-for-multi-stage-query-engine
branch
from
1e614e2 to
b3e6817
Compare
xiangfu0
force-pushed
the
11251-create-a-separated-query-endpoint-for-multi-stage-query-engine
branch
from
b3e6817 to
f24e48c
Compare
xiangfu0
deleted the
11251-create-a-separated-query-endpoint-for-multi-stage-query-engine
branch
Jackie-Jiang
added
rest-api
release-notes
Contributor
|
Please add these new APIs to the pinot doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #11251 , create two new Broker API endpoints for multi-stage query engine.
Make Integration tests to use new endpoint for testing multi-stage engine.