Skip to content

Cleanup HLC code #11326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jackie-Jiang merged 4 commits into from
Aug 14, 2023
Merged

Cleanup HLC code #11326

Jackie-Jiang merged 4 commits into from
Aug 14, 2023

Conversation

@navina
Copy link
Contributor

@navina navina commented Aug 11, 2023 •
edited
Loading

Follow-up for #11017 where we removed support for high/stream level consumers in Apache Pinot. This PR makes the following changes:

  • Deletes the kafka and pulsar stream level connectors
  • Removes HLRealtimeSegmentDataManager and support for it in RealtimeTableDataManager
  • Made pinot-spi changes in StreamConsumerFactory#createStreamLevelConsumer to throw UnsupportedException by default

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.50%. Comparing base (d6b1b4f) to head (1560d7b).
⚠️ Report is 3481 commits behind head on master.

Files with missing lines Patch % Lines
...ata/manager/realtime/RealtimeTableDataManager.java 86.66% 1 Missing and 1 partial ⚠️
...apache/pinot/spi/stream/StreamConsumerFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             master   #11326       +/-   ##
=============================================
+ Coverage      0.11%   68.50%   +68.39%     
- Complexity        0     6536     +6536     
=============================================
  Files          2239     2233        -6     
  Lines        120424   119927      -497     
  Branches      18215    18183       -32     
=============================================
+ Hits            137    82161    +82024     
+ Misses       120267    31931    -88336     
- Partials         20     5835     +5815
Flag Coverage Δ
integration1 21.04% <75.00%> (?)
integration1temurin11 ?
integration1temurin17 ?
integration1temurin20 ?
integration2 25.64% <75.00%> (?)
integration2temurin11 ?
integration2temurin17 ?
integration2temurin20 ?
java-11 68.39% <81.25%> (?)
java-17 68.30% <81.25%> (?)
java-20 68.28% <81.25%> (?)
temurin 68.50% <81.25%> (?)
unittests1 67.33% <12.50%> (?)
unittests1temurin17 ?
unittests1temurin20 ?
unittests2 14.66% <0.00%> (?)
unittests2temurin11 ?
unittests2temurin17 ?
unittests2temurin20 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@navina navina marked this pull request as ready for review August 12, 2023 06:06
xiangfu0
xiangfu0 approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jackie-Jiang Jackie-Jiang merged commit f25f3ed into apache:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jackie-Jiang Jackie-Jiang Jackie-Jiang left review comments

@xiangfu0 xiangfu0 xiangfu0 approved these changes

Assignees

No one assigned

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@navina @codecov-commenter @xiangfu0 @Jackie-Jiang