refactor argmin/max to exprmin/max and make it calcite compliant #11296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11296 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2230 2231 +1
Lines 120140 120151 +11
Branches 18218 18218
==========================================
Hits 137 137
- Misses 119983 119994 +11
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
approved these changes
Aug 8, 2023
xiangfu0
reviewed
Aug 8, 2023
| PARENTARGMAX(CommonConstants.RewriterConstants.PARENT_AGGREGATION_NAME_PREFIX + ARGMAX.getName()), | ||
| CHILDARGMIN(CommonConstants.RewriterConstants.CHILD_AGGREGATION_NAME_PREFIX + ARGMIN.getName()), | ||
| CHILDARGMAX(CommonConstants.RewriterConstants.CHILD_AGGREGATION_NAME_PREFIX + ARGMAX.getName()), | ||
| EXPRMIN("exprMin"), |
Contributor
There was a problem hiding this comment.
You may need to update here for making v2 query engine work
Contributor
Author
There was a problem hiding this comment.
Updated, PTAL, thanks!
Jackie-Jiang
added
enhancement
release-notes
Contributor
|
@jasperjiaguo - can we update the user docs please when you get a chance ? |
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR for #11254
Rename argmin/max function to exprmin/max, swap the measuring/projection column
new signature:
exprmin/max(projectCol, measureCol1 [, measureCol2]*)