Skip to content

Conversation

@Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Aug 4, 2023

Added partition_parallelism as TableHintOptions so that we can increase parallelism per partition for intermediate stage after partitioned table scan stage

@Jackie-Jiang Jackie-Jiang added enhancement multi-stage Related to the multi-stage query engine labels Aug 4, 2023
@Jackie-Jiang Jackie-Jiang requested a review from walterddr August 4, 2023 07:43
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

❌ Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.02%. Comparing base (2b40362) to head (5672fe9).
⚠️ Report is 3364 commits behind head on master.

Files with missing lines Patch % Lines
.../org/apache/pinot/query/routing/WorkerManager.java 88.46% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11266      +/-   ##
============================================
+ Coverage     62.99%   63.02%   +0.03%     
- Complexity     1107     1108       +1     
============================================
  Files          2303     2303              
  Lines        124041   124078      +37     
  Branches      18895    18902       +7     
============================================
+ Hits          78137    78203      +66     
+ Misses        40352    40319      -33     
- Partials       5552     5556       +4     
Flag Coverage Δ
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 62.97% <95.16%> (+<0.01%) ⬆️
java-17 62.86% <95.16%> (+0.01%) ⬆️
java-20 62.88% <95.16%> (+0.02%) ⬆️
temurin 63.02% <95.16%> (+0.03%) ⬆️
unittests 63.02% <95.16%> (+0.03%) ⬆️
unittests1 67.54% <95.16%> (+0.01%) ⬆️
unittests2 14.49% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackie-Jiang Jackie-Jiang force-pushed the stage_parallelism_on_partitioned_scan branch from 62270df to 9332d9f Compare August 9, 2023 19:00
@Jackie-Jiang Jackie-Jiang force-pushed the stage_parallelism_on_partitioned_scan branch from 9332d9f to 5672fe9 Compare August 25, 2023 21:22
@Jackie-Jiang Jackie-Jiang added the release-notes Referenced by PRs that need attention when compiling the next release notes label Aug 25, 2023
@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 August 25, 2023 21:24
@Jackie-Jiang Jackie-Jiang merged commit 5faa792 into apache:master Aug 25, 2023
@Jackie-Jiang Jackie-Jiang deleted the stage_parallelism_on_partitioned_scan branch August 25, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement multi-stage Related to the multi-stage query engine release-notes Referenced by PRs that need attention when compiling the next release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants