Skip to content

Add SchemaConformingTransformer to transform records with varying keys to fit a table's schema without dropping fields. #11210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenboat merged 7 commits into from
Aug 24, 2023
Merged

Add SchemaConformingTransformer to transform records with varying keys to fit a table's schema without dropping fields. #11210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
379926b
Add JsonLogTransformer to transform semi-structured log events to fit…
kirkrodrigues Jul 27, 2023
d077c10
Minor fix
kirkrodrigues Jul 27, 2023
ca89cff
Add unit tests for JsonLogTransformer.
kirkrodrigues Jul 28, 2023
9ad0b87
Minor fixes.
kirkrodrigues Jul 28, 2023
6ad75da
Refactor docstrings.
kirkrodrigues Aug 10, 2023
816512b
Rename JsonLogTransformer to SchemaConformingTransformer
kirkrodrigues Aug 22, 2023
a21abab
JsonLogTransformer: Pass through GenericRow's special keys
kirkrodrigues Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pinot-core/src/test/java/org/apache/pinot/queries/TransformQueriesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ protected void buildSegment()
.setIngestionConfig(new IngestionConfig(null, null, null,
Arrays.asList(new TransformConfig(M1_V2, "Groovy({INT_COL1_V3 == null || "
+ "INT_COL1_V3 == Integer.MIN_VALUE ? INT_COL1 : INT_COL1_V3 }, INT_COL1, INT_COL1_V3)")),
null, null))
null, null, null))
.build();
Schema schema =
new Schema.SchemaBuilder().setSchemaName(TABLE_NAME).addSingleValueDimension(D1, FieldSpec.DataType.STRING)
Expand Down
13 changes: 9 additions & 4 deletions .../src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ public class CompositeTransformer implements RecordTransformer {
* destination columns
* </li>
* <li>
* {@link DataTypeTransformer} after {@link FilterTransformer} to convert values to comply with the schema
* Optional {@link SchemaConformingTransformer} after {@link FilterTransformer}, so that we can transform input
* records that have varying fields to a fixed schema without dropping any fields
* </li>
* <li>
* {@link DataTypeTransformer} after {@link SchemaConformingTransformer} to convert values to comply with the
* schema
* </li>
* <li>
* Optional {@link TimeValidationTransformer} after {@link DataTypeTransformer} so that time value is converted to
Expand All @@ -67,9 +72,9 @@ public class CompositeTransformer implements RecordTransformer {
public static CompositeTransformer getDefaultTransformer(TableConfig tableConfig, Schema schema) {
return new CompositeTransformer(
Stream.of(new ExpressionTransformer(tableConfig, schema), new FilterTransformer(tableConfig),
new DataTypeTransformer(tableConfig, schema), new TimeValidationTransformer(tableConfig, schema),
new NullValueTransformer(tableConfig, schema), new SanitizationTransformer(schema))
.filter(t -> !t.isNoOp()).collect(Collectors.toList()));
new SchemaConformingTransformer(tableConfig, schema), new DataTypeTransformer(tableConfig, schema),
new TimeValidationTransformer(tableConfig, schema), new NullValueTransformer(tableConfig, schema),
new SanitizationTransformer(schema)).filter(t -> !t.isNoOp()).collect(Collectors.toList()));
}

/**
Expand Down
Loading