[multistage] Add numGroupsLimitReached metrics to broker v2 queries #11023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11023 +/- ##
=============================================
- Coverage 63.00% 14.47% -48.53%
+ Complexity 1094 201 -893
=============================================
Files 2302 2302
Lines 124025 124029 +4
Branches 18901 18903 +2
=============================================
- Hits 78137 17950 -60187
- Misses 40338 104562 +64224
+ Partials 5550 1517 -4033
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1471 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ankitsultana
reviewed
Jul 1, 2023
...ker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
walterddr
reviewed
Jul 25, 2023
...ker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
tibrewalpratik17
force-pushed
the
add_broker_metrics_v2
branch
from
1cfc84b to
c0c392b
Compare
Contributor
Author
|
Closing this as we have moved to using broker-event-listener framework for tracking these metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels:
multistagenumGroupsLimitReached metric was emitted in v1 but was not getting emitted for v2 queries. Adding that support.
This is also called out as a task in #10781
cc @ankitsultana @walterddr