-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Remove support for High level consumers in Apache Pinot #11017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11017 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2227 2229 +2
Lines 119633 119827 +194
Branches 18105 18127 +22
==========================================
Hits 137 137
- Misses 119476 119670 +194
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6b03933 to
3b13759
Compare
2c94968 to
f95ca86
Compare
f745dc8 to
45942f2
Compare
ebce99b to
b2aa741
Compare
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
Outdated
Show resolved
Hide resolved
...-controller/src/test/java/org/apache/pinot/controller/api/PinotTableRestletResourceTest.java
Outdated
Show resolved
Hide resolved
...re/src/test/java/org/apache/pinot/core/realtime/impl/fakestream/FakeStreamLevelConsumer.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfig.java
Outdated
Show resolved
Hide resolved
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
Outdated
Show resolved
Hide resolved
pinot-core/src/test/java/org/apache/pinot/core/util/SchemaUtilsTest.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/test/java/org/apache/pinot/broker/broker/FakeStreamConsumerFactory.java
Outdated
Show resolved
Hide resolved
ea34fc6 to
fe9fc12
Compare
- Disable integration tests - Throw runtime exception in controller startup script
… "simple" and from quickstarts
…g only once in the validate call path
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
@Deprecatedin pinot-spi (discourages new plugin development)Related to the discussions in #10996
Label:
backward-incompatcc : @Jackie-Jiang @mcvsubbu @xiangfu0