Skip to content

Conversation

@navina
Copy link
Contributor

@navina navina commented Jun 30, 2023

  • Controller will throw runtime exception during startup if there are hlc tables in the cluster (disallows cluster upgrade)
  • Add table api will disallow table creation with consumer.type = highlevel (disallows new table creation)
  • Marked StreamLevelConsumer as @Deprecated in pinot-spi (discourages new plugin development)

Related to the discussions in #10996

Label: backward-incompat
cc : @Jackie-Jiang @mcvsubbu @xiangfu0

@navina navina marked this pull request as ready for review June 30, 2023 21:52
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #11017 (e3eb8ce) into master (030d9c0) will decrease coverage by 0.01%.
Report is 8 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #11017      +/-   ##
==========================================
- Coverage    0.11%    0.11%   -0.01%     
==========================================
  Files        2227     2229       +2     
  Lines      119633   119827     +194     
  Branches    18105    18127      +22     
==========================================
  Hits          137      137              
- Misses     119476   119670     +194     
  Partials       20       20              
Flag Coverage Δ
integration1temurin11 0.00% <0.00%> (ø)
integration1temurin17 0.00% <0.00%> (ø)
integration1temurin20 0.00% <0.00%> (ø)
integration2temurin11 0.00% <0.00%> (ø)
unittests1temurin11 0.00% <0.00%> (ø)
unittests1temurin17 0.00% <0.00%> (ø)
unittests1temurin20 0.00% <0.00%> (ø)
unittests2temurin11 0.11% <0.00%> (-0.01%) ⬇️
unittests2temurin17 0.11% <0.00%> (-0.01%) ⬇️
unittests2temurin20 0.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...apache/pinot/controller/BaseControllerStarter.java 0.00% <0.00%> (ø)
...va/org/apache/pinot/controller/ControllerConf.java 0.00% <0.00%> (ø)
...ntroller/helix/core/PinotHelixResourceManager.java 0.00% <0.00%> (ø)
...lugin/stream/kafka20/KafkaStreamLevelConsumer.java 0.00% <ø> (ø)
...lugin/stream/pulsar/PulsarStreamLevelConsumer.java 0.00% <ø> (ø)
...he/pinot/segment/local/utils/TableConfigUtils.java 0.00% <0.00%> (ø)
...java/org/apache/pinot/spi/stream/StreamConfig.java 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@navina navina force-pushed the remove-hlc branch 2 times, most recently from 6b03933 to 3b13759 Compare July 3, 2023 06:52
@navina navina marked this pull request as draft July 4, 2023 05:21
@navina navina force-pushed the remove-hlc branch 5 times, most recently from 2c94968 to f95ca86 Compare July 8, 2023 06:30
@navina navina force-pushed the remove-hlc branch 3 times, most recently from f745dc8 to 45942f2 Compare July 13, 2023 18:26
@Jackie-Jiang Jackie-Jiang added incompatible Indicate PR that introduces backward incompatibility backward-incompat Referenced by PRs that introduce or fix backward compat issues labels Jul 19, 2023
@navina navina force-pushed the remove-hlc branch 4 times, most recently from ebce99b to b2aa741 Compare July 22, 2023 07:02
@navina navina marked this pull request as ready for review July 24, 2023 17:30
@navina navina force-pushed the remove-hlc branch 2 times, most recently from ea34fc6 to fe9fc12 Compare July 28, 2023 05:55
@navina navina requested a review from Jackie-Jiang July 28, 2023 17:35
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backward-incompat Referenced by PRs that introduce or fix backward compat issues incompatible Indicate PR that introduces backward incompatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants