update segment target tier before table rebalance #10695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10695 +/- ##
============================================
- Coverage 68.44% 64.24% -4.21%
+ Complexity 6421 6408 -13
============================================
Files 2107 2053 -54
Lines 113792 111304 -2488
Branches 17199 16903 -296
============================================
- Hits 77887 71502 -6385
- Misses 30369 34636 +4267
+ Partials 5536 5166 -370
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 370 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
npawar
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make index config tier overwriting #10553 more robust.
Turns out the fix in #10642 is not enough, e.g. if one updates tierConfigs in table config and calls rebalance API to move segments around and it happens before SegmentRelocator task kicks in to update the segment target tiers, it's still possible that segments are loaded on the new servers without using the tier specific index configs. So moving the logic that updates segment target tier into
rebalanceTablemethod to be shared by both table rebalance API and SegmentRelocator periodic task.