[multistage] Add some additional planner tests for ROW_NUMBER() window function #10684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10684 +/- ##
=============================================
- Coverage 68.47% 13.82% -54.66%
+ Complexity 6507 439 -6068
=============================================
Files 2108 2054 -54
Lines 113904 111417 -2487
Branches 17192 16895 -297
=============================================
- Hits 77997 15402 -62595
- Misses 30354 94757 +64403
+ Partials 5553 1258 -4295
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1623 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| ] | ||
| }, | ||
| { | ||
| "description": "single OVER(ORDER BY) row_number and select col with global order by on different column as inside over", |
Contributor
There was a problem hiding this comment.
What about corresponding runtime tests for these variants ? Especially for the JOIN one ?
Can be done separately if not already covered
Contributor
Author
There was a problem hiding this comment.
Yeah the JOIN one needs a bit more work and I'll add that as part of RANK/DENSE_RANK support or as a separate PR to cover more JOIN scenarios.
siddharthteotia
approved these changes
Apr 25, 2023
yashmayya
added
the
window-functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the review comments on the
ROW_NUMBER()window functions PR: #10587cc @siddharthteotia @vvivekiyer @walterddr
Overall window functions issue - #7213