Skip to content

Conversation

@tibrewalpratik17
Copy link
Contributor

Follow up to #10336

As pointed by @walterddr in #10546 that

the error message for multi-stage query for select * from non_exist_tbl will return cannot find common tenant across all tables: ['non_exist_tbl']

This PR would search for non-existent tables and the error message will be: Unable to find table : non_exist_tbl

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #10599 (73102a6) into master (0cb456a) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master   #10599      +/-   ##
============================================
- Coverage     70.37%   70.36%   -0.01%     
- Complexity     6495     6496       +1     
============================================
  Files          2106     2106              
  Lines        113004   113016      +12     
  Branches      17026    17028       +2     
============================================
+ Hits          79521    79526       +5     
  Misses        27917    27917              
- Partials       5566     5573       +7     
Flag Coverage Δ
integration1 24.43% <71.42%> (-0.11%) ⬇️
integration2 24.10% <0.00%> (+0.09%) ⬆️
unittests1 67.98% <ø> (+<0.01%) ⬆️
unittests2 13.89% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/controller/api/resources/PinotQueryResource.java 60.86% <71.42%> (+1.31%) ⬆️

... and 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr requested a review from Jackie-Jiang April 13, 2023 18:12
@Jackie-Jiang Jackie-Jiang added enhancement multi-stage Related to the multi-stage query engine labels Apr 18, 2023
@Jackie-Jiang Jackie-Jiang merged commit 873cc0a into apache:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement multi-stage Related to the multi-stage query engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants