Skip to content

[multistage] Catch Throwable To Propagate Proper Error Message #10438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiangfu0 merged 1 commit into from
Mar 17, 2023
Merged

[multistage] Catch Throwable To Propagate Proper Error Message #10438

xiangfu0 merged 1 commit into from
Mar 17, 2023
+2 −2

Conversation

@ankitsultana
Copy link
Contributor

@ankitsultana ankitsultana commented Mar 17, 2023

minor change. Calcite can throw Error as well which doesn't get caught and returns a error with no details whatsoever.

Example:

<html><head><title>Grizzly 2.4.4</title><style><!--div.header {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#003300;font-size:22px;-moz-border-radius-topleft: 10px;border-top-left-radius: 10px;-moz-border-radius-topright: 10px;border-top-right-radius: 10px;padding-left: 5px}div.body {font-family:Tahoma,Arial,sans-serif;color:black;background-color:#FFFFCC;font-size:16px;padding-top:10px;padding-bottom:10px;padding-left:10px}div.footer {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#666633;font-size:14px;-moz-border-radius-bottomleft: 10px;border-bottom-left-radius: 10px;-moz-border-radius-bottomright: 10px;border-bottom-right-radius: 10px;padding-left: 5px}BODY {font-family:Tahoma,Arial,sans-serif;color:black;background-color:white;}B {font-family:Tahoma,Arial,sans-serif;color:black;}A {color : black;}HR {color : #999966;}--></style> </head><body><div class="header">Request failed.</div><div class="body">Request failed.</div><div class="footer">Grizzly 2.4.4</div></body></html>

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023 •
edited
Loading

Codecov Report

Merging #10438 (878c192) into master (0362ad3) will increase coverage by 35.15%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master   #10438       +/-   ##
=============================================
+ Coverage     35.14%   70.30%   +35.15%     
- Complexity      282     6128     +5846     
=============================================
  Files          2053     2056        +3     
  Lines        111402   111534      +132     
  Branches      16940    16962       +22     
=============================================
+ Hits          39157    78411    +39254     
+ Misses        68835    27605    -41230     
- Partials       3410     5518     +2108
Flag Coverage Δ
integration1 24.33% <0.00%> (-0.14%) ⬇️
integration2 24.27% <0.00%> (-0.03%) ⬇️
unittests1 67.95% <100.00%> (?)
unittests2 13.82% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/org/apache/pinot/query/QueryEnvironment.java 93.33% <100.00%> (+93.33%) ⬆️

... and 1163 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 merged commit bf5528c into apache:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangfu0 xiangfu0 xiangfu0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ankitsultana @codecov-commenter @xiangfu0